Fix false InvalidArgument for sprintf precision placeholders#11729
Merged
Fix false InvalidArgument for sprintf precision placeholders#11729
Conversation
Fix vimeo#11721 Psalm validates some sprintf/printf formats by calling them with dummy values. For .* precision placeholders that used empty strings, PHP 8 raises a false ValueError and Psalm reported InvalidArgument. Validate complex * width and precision placeholders with integer dummies before falling back to the generic return type. Add regressions for %.*f, positional variants, and related arity errors.
eyupcanakman
added a commit
to eyupcanakman/endtoend-test-collections
that referenced
this pull request
Mar 15, 2026
Update psalm-baseline.xml for vimeo/psalm#11729. The sprintf precision placeholder fix removes several Missing* baseline entries in this fixture project, so the baseline needs to be regenerated with the current Psalm branch.
danog
added
the
release:fix
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #11721
Psalm validates some sprintf/printf formats by calling them with dummy values. For
.*precision placeholders that used empty strings, PHP 8 raises a falseValueErrorand Psalm reportedInvalidArgument.Validate complex
*width and precision placeholders with integer dummies before falling back to the generic return type. Add regressions for%.*f, positional variants, and related arity errors.